feature/ Add encryptionScheme=C4GH when calling htsget-rs#632
Merged
KarlG-nbis merged 3 commits intomainfrom Feb 11, 2026
Merged
feature/ Add encryptionScheme=C4GH when calling htsget-rs#632KarlG-nbis merged 3 commits intomainfrom
KarlG-nbis merged 3 commits intomainfrom
Conversation
KarlG-nbis
force-pushed
the
feature/htsget_add_encryption_scheme
branch
from
597b4ba to
fa74127
Compare
zeidlitz
reviewed
Dec 11, 2025
pahatz
approved these changes
Dec 11, 2025
Contributor
Author
|
Might pend another change as encountered another issue with c4gh keys and waiting for solution after discussion with Marko at: https://nbisweden.slack.com/archives/C063YCMEP6W/p1764231464294689 |
…Key when calling htsget, but keep Client-Public-Key when calling sda-download
KarlG-nbis
force-pushed
the
feature/htsget_add_encryption_scheme
branch
from
ddf404b to
7da55f8
Compare
Contributor
Author
|
PR is now ready for review again after update in the htsget-rs application which requires the |
zeidlitz
approved these changes
Feb 5, 2026
nanjiangshu
approved these changes
Feb 5, 2026
Contributor
nanjiangshu
left a comment
nanjiangshu
left a comment
There was a problem hiding this comment.
Looks good to me!
However, the way the URL is concatenated like this
url := htsgetHost + "/reads/" + datasetID + "/" + fileName + "?encryptionScheme=C4GH
is not ideal, probably better to use path.Join
But this is used at multiple places in the sda-cli code base, we can probably fix this in a refactoring issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #631 .
Description
Adds encryptionScheme=C4GH when calling htsget-rs