fix: do not print host_base to stdout#530
Merged
MalinAhlberg merged 2 commits intomainfrom Mar 28, 2025
Merged
Conversation
jbygdell
approved these changes
Mar 27, 2025
Contributor
jbygdell
left a comment
There was a problem hiding this comment.
Two unnecessary blank lines but else fine.
ffd4692 to
9d137a5
Compare
Member
Author
|
I have applied Jocke's suggestion, rebased on main, and fixed the integration test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #525 .
Description
helpers, to simplify the process in case we want to update the message in the future.How to test
For example, run
And make sure the info about the host base is in stderr.
Also test that counting the number of files works:
And similarly for
download.