[list] use pagination to list s3 objects#513
Merged
Conversation
aaperis
force-pushed
the
feature/pagination-of-list-files
branch
from
a143d84 to
48af8cc
Compare
- adjust upload.go accordingly
by making maxKeys as arg to ListFiles
so that the code is more readable
aaperis
force-pushed
the
feature/pagination-of-list-files
branch
from
884d5a0 to
ace1d21
Compare
nanjiangshu
approved these changes
Mar 9, 2025
Contributor
nanjiangshu
left a comment
nanjiangshu
left a comment
There was a problem hiding this comment.
Works well when I tested! Great job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #502 .
Description
ListFilesfunction checks to see if there are more than the returned results and makes subsequent calls until it retrieves all the object info.ListFilesfunction (which were missing) along with tests for list paginationHow to test
Easy way: run
go test ./helpersOther way: Upload 1001 files in a bucket and try to list with sda-cli