Merged
Conversation
aaperis
force-pushed
the
feature/resume-upload-from-breakpoint
branch
2 times, most recently
from
cbe99bf to
7d08577
Compare
nanjiangshu
reviewed
Feb 20, 2025
nanjiangshu
reviewed
Feb 20, 2025
nanjiangshu
reviewed
Feb 20, 2025
nanjiangshu
reviewed
Feb 20, 2025
nanjiangshu
reviewed
Feb 20, 2025
nanjiangshu
reviewed
Feb 20, 2025
nanjiangshu
reviewed
Feb 20, 2025
nanjiangshu
reviewed
Feb 20, 2025
nanjiangshu
reviewed
Feb 20, 2025
nanjiangshu
reviewed
Feb 20, 2025
nanjiangshu
reviewed
Feb 20, 2025
Contributor
nanjiangshu
left a comment
nanjiangshu
left a comment
There was a problem hiding this comment.
Work great when I tested manually! I added a few comments about the messages and also the README for potential clarification and improvement.
MalinAhlberg
approved these changes
Feb 20, 2025
Member
MalinAhlberg
left a comment
MalinAhlberg
left a comment
There was a problem hiding this comment.
Great! Except for the comments from @nanjiangshu, I think it looks all good and works well when tested.
aaperis
force-pushed
the
feature/resume-upload-from-breakpoint
branch
from
52ee932 to
ade8a1f
Compare
Contributor
Author
Thanks for the suggestions @nanjiangshu! I added all of them and I think the text is now much improved. |
aaperis
force-pushed
the
feature/resume-upload-from-breakpoint
branch
from
ade8a1f to
e203e49
Compare
aaperis
force-pushed
the
feature/resume-upload-from-breakpoint
branch
from
e203e49 to
000fb34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #461 .
Description
A new boolean flag
--continueis added. If provided, the sda-cli will not throw an error when trying to upload an already uploaded file. Instead, it will return a message that a file is already uploaded and will skip it during upload and continue with the next one.This is a more generic fix than just implementing the same functionality only for recursive upload of folders since now this works also for a list of files given as arguments. I also chose to name the flag
--continueinstead of--resumebecause it seems more accurate since--resumemay be understood as resuming partial uploads which is not the case.I also did some small refactoring to the logic of
force-overwriteso that if this flag is used the code will not try to check if files are already uploaded, thus saving some resources here.How to test
Tests added as integration tests. These should pass.