More human friendly token expiry date messages#498
Merged
Conversation
aaperis
force-pushed
the
feature/token-expiry-date
branch
from
b5e0f5e to
cb8bd2f
Compare
jbygdell
reviewed
Jan 24, 2025
Contributor
jbygdell
left a comment
jbygdell
left a comment
There was a problem hiding this comment.
While you ar at it consider changing the default response of the switch to handle the case of an expired token.
The logical cases would then be:
1-120 min, 2-24 hours and > 24 hours.
Contributor
Author
Makes, sense. Done. |
aaperis
force-pushed
the
feature/token-expiry-date
branch
from
abc7dde to
4874d03
Compare
nanjiangshu
reviewed
Jan 30, 2025
nanjiangshu
reviewed
Jan 30, 2025
Contributor
nanjiangshu
left a comment
nanjiangshu
left a comment
There was a problem hiding this comment.
Looks great! I l left a minor comment for improvement but I'm OK to ignore it as well.
aaperis
force-pushed
the
feature/token-expiry-date
branch
from
4874d03 to
3fad701
Compare
jbygdell
reviewed
Jan 31, 2025
jbygdell
approved these changes
Jan 31, 2025
nanjiangshu
approved these changes
Jan 31, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #437. Now token expiry messages to the user follow the output pattern that is listed in the issue description.
How to test
Tests have been added to the go testsuite, so
should be enough.
Note: The
download integrationtests fail because of the latest change wheresda-downloadserves only/s3whereassda-clilooks fors3-encrypted. This is irrelevant to this PR though (see temporary fix #501)