Skip to content

Public key file permissions set to full read access#452

Merged
jbygdell merged 3 commits intomainfrom
feat/public-key-read-access
Sep 20, 2024
Merged

Public key file permissions set to full read access#452
jbygdell merged 3 commits intomainfrom
feat/public-key-read-access

Conversation

@MalinAhlberg
Copy link
Copy Markdown
Member

Related issue(s) and PR(s)
This PR closes #410 .

Description

  • The key pair created by sda-cli is now:

    $sda-cli createKey keys
    $ls -l
    -rw------- 1 malin malin      255 Sep 19 16:36 keys.sec.pem
    -rw-r--r-- 1 malin malin      115 Sep 19 16:36 keys.pub.pem
    
  • A test case is added.

How to test
sda-cli createKey testkeys

@MalinAhlberg MalinAhlberg requested review from a team and removed request for a team September 19, 2024 14:38
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.17%. Comparing base (d21a0c9) to head (a88ed96).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   39.17%   39.17%           
=======================================
  Files          11       11           
  Lines        1922     1922           
=======================================
  Hits          753      753           
  Misses       1058     1058           
  Partials      111      111           
Flag Coverage Δ
unittests 39.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MalinAhlberg MalinAhlberg requested a review from a team September 19, 2024 14:57
Copy link
Copy Markdown
Contributor

@nanjiangshu nanjiangshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jbygdell jbygdell added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 9335ca6 Sep 20, 2024
@jbygdell jbygdell deleted the feat/public-key-read-access branch September 20, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

change the permission for the public key created by sda-cli to 644

4 participants