Conversation
kostas-kou
requested review from
MalinAhlberg,
aaperis,
jbygdell,
nanjiangshu and
pahatz
nanjiangshu
left a comment
nanjiangshu
left a comment
There was a problem hiding this comment.
Looks good. Just added a few minor comments.
When testing, I failed to upload a file to the bigpicture with the following command:
sda-cli upload -config s3cmd-bp.conf -encrypt-with-key c4gh.pub.pem t1.txt
The error message is strange and I have never seen before
FATA[0014] SerializationError: failed to unmarshal error message
status code: 502, request id: , host id:
caused by: UnmarshalError: failed to unmarshal error message
00000000 3c 68 74 6d 6c 3e 0d 0a 3c 68 65 61 64 3e 3c 74 |<html>..<head><t|
00000010 69 74 6c 65 3e 35 30 32 20 42 61 64 20 47 61 74 |itle>502 Bad Gat|
00000020 65 77 61 79 3c 2f 74 69 74 6c 65 3e 3c 2f 68 65 |eway</title></he|
00000030 61 64 3e 0d 0a 3c 62 6f 64 79 3e 0d 0a 3c 63 65 |ad>..<body>..<ce|
00000040 6e 74 65 72 3e 3c 68 31 3e 35 30 32 20 42 61 64 |nter><h1>502 Bad|
00000050 20 47 61 74 65 77 61 79 3c 2f 68 31 3e 3c 2f 63 | Gateway</h1></c|
00000060 65 6e 74 65 72 3e 0d 0a 3c 68 72 3e 3c 63 65 6e |enter>..<hr><cen|
00000070 74 65 72 3e 6e 67 69 6e 78 3c 2f 63 65 6e 74 65 |ter>nginx</cente|
00000080 72 3e 0d 0a 3c 2f 62 6f 64 79 3e 0d 0a 3c 2f 68 |r>..</body>..</h|
00000090 74 6d 6c 3e 0d 0a
I hope this is related to safespring storage migration, or?
MalinAhlberg
left a comment
MalinAhlberg
left a comment
There was a problem hiding this comment.
Nice @kostas-kou !
Also good suggestions from @nanjiangshu! I left one suggestion, and also wonder whether -bytes should be mentioned?
Co-authored-by: Nanjiang Shu <nanjiang.shu@gmail.com>
Co-authored-by: Alex Aperis <76202622+aaperis@users.noreply.github.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage 39.17% 39.17%
=======================================
Files 11 11
Lines 1922 1922
=======================================
Hits 753 753
Misses 1058 1058
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The information about the --bytes flag is added as well @MalinAhlberg |
5 participants
Related issue(s) and PR(s)
This PR closes #432.
Description
Documentation was added for listing accessible datasets and their files
How to test