deprecate download, replace with sda-download#427
Merged
MalinAhlberg merged 9 commits intomainfrom Aug 13, 2024
Merged
Conversation
MalinAhlberg
force-pushed
the
feat/deprecate-download
branch
from
1151d9c to
26f6e18
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
- Coverage 41.24% 39.29% -1.96%
==========================================
Files 13 11 -2
Lines 2051 1891 -160
==========================================
- Hits 846 743 -103
+ Misses 1084 1036 -48
+ Partials 121 112 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
as it was depending on deprecated download
MalinAhlberg
force-pushed
the
feat/deprecate-download
branch
from
8a6cfa9 to
4faf382
Compare
jbygdell
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #398 .
Description
download(eg./sda-cli download <urls_file>) is deprecated and removed./sda-cli datasetsize <urls_file>) as it was dependent on the now deprecated function for downloading files withurls_file.sda-download(./sda-cli sda-download) renamed todownloadHow to test
./sda-cli download -config <configuration_file> -dataset-id <datasetID> -url <download-service-URL> <filepath>./sda-cli download -pubkey <public-key-file> -config <configuration_file> -dataset-id <datasetID> -url <download-service-url>