Skip to content

Airflow version 2.10.3 upgrade and code improvements to resolve sonar findings#151

Merged
ramesh-maddegoda merged 15 commits into
mainfrom
airflow-version-upgrade
May 22, 2025
Merged

Airflow version 2.10.3 upgrade and code improvements to resolve sonar findings#151
ramesh-maddegoda merged 15 commits into
mainfrom
airflow-version-upgrade

Conversation

@ramesh-maddegoda

@ramesh-maddegoda ramesh-maddegoda commented May 19, 2025

Copy link
Copy Markdown
Contributor

🗒️ Summary

This pull request upgrades the Airflow version of Nucleus to version 2.10.3. In future, we plan to upgrade Airflow version to 3.x. This version 2.10.3 upgrade is conducted to make the transition from Airflow 2.x to Airflow 3.x a smooth transition in future. Also, this pull request introduces some code improvements made to address sonar findings related with adding logs buckets for S3 buckets. In addition, this adds parameter validation for Airflow S3 backlog processing DAG parameters.

⚙️ Test Data and/or Report

  • Screenshot showing the new Airflow version 2.10.3
Screenshot 2025-05-19 at 11 56 34 AM
  • Screenshot showing the parameter validation for Airflow S3 backlog processing DAG parameters
Screenshot 2025-05-19 at 11 58 27 AM

♻️ Related Issues

Upgrade Nucleus Airflow version to 2.10.3 #150

@jordanpadams jordanpadams left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramesh-maddegoda it looks like the secrets.baseline is still not quite right. can you try regenerating again?

https://github.com/NASA-PDS/nasa-pds.github.io/wiki/Git-and-Github-Guide#detect-secrets

@ramesh-maddegoda

Copy link
Copy Markdown
Contributor Author

@ramesh-maddegoda it looks like the secrets.baseline is still not quite right. can you try regenerating again?

https://github.com/NASA-PDS/nasa-pds.github.io/wiki/Git-and-Github-Guide#detect-secrets

@jordanpadams , I used the following command for secret detection and pushes it again.

detect-secrets scan --disable-plugin AbsolutePathDetectorExperimental \
    --exclude-files '\.secrets\..*' \
    --exclude-files '\.git.*' \
    --exclude-files '\.pre-commit-config\.yaml' \
    --exclude-files '\.mypy_cache' \
    --exclude-files '\.pytest_cache' \
    --exclude-files '\.tox' \
    --exclude-files '\.venv' \
    --exclude-files 'venv' \
    --exclude-files 'dist' \
    --exclude-files 'build' \
    --exclude-files '.*\.egg-info' \
    --exclude-files '.*\.tfstate' \
    --exclude-files '.*\.tfvars' \
    > .secrets.baseline

detect-secrets audit .secrets.baseline


@jordanpadams

Copy link
Copy Markdown
Member

@ramesh-maddegoda I would use this in the future to ensure it matches what is in the build:

https://github.com/NASA-PDS/nucleus/blob/main/.github/workflows/secrets-detection.yaml#L47

If that is not what you expect, please update that YAML file so whatever you are running matches what the build is doing.

@jordanpadams

Copy link
Copy Markdown
Member

@sjoshi-jpl can you please review this?

@jordanpadams

Copy link
Copy Markdown
Member

@ramesh-maddegoda can you review the security hotspot and triage appropriately?

@ramesh-maddegoda

Copy link
Copy Markdown
Contributor Author

@ramesh-maddegoda can you review the security hotspot and triage appropriately?

@jordanpadams all security hotspots are resolved now.

@sonarqubecloud

Copy link
Copy Markdown

@ramesh-maddegoda ramesh-maddegoda merged commit f3407a2 into main May 22, 2025
2 checks passed
@ramesh-maddegoda ramesh-maddegoda deleted the airflow-version-upgrade branch May 22, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants