Add API integration test mode to aerie-action-demo#1909
Merged
Conversation
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
test/seq-metadata-tests
branch
from
db09a91 to
b6c883e
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
test/seq-metadata-tests
branch
from
b6c883e to
5c9f9b0
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
test/seq-metadata-tests
branch
from
5c9f9b0 to
6a83f32
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
dandelany
reviewed
Apr 22, 2026
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
dandelany
approved these changes
Apr 22, 2026
Collaborator
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
Looks good, I feel much better about the actions API with these tests in place!
General stylistic note - i'd prefer using assert(x, y) in place of a lot of the if(x) { y } just for conciseness, but no biggie
duranb
requested changes
Apr 22, 2026
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
… Collect and surface action run errors in e2e tests.
dandelany
force-pushed
the
test/seq-metadata-tests
branch
from
81a4e61 to
e78b274
Compare
duranb
approved these changes
Apr 22, 2026
JosephVolosin
pushed a commit
that referenced
this pull request
Apr 23, 2026
* Add API integration test mode to aerie-action-demo. Update aerie-action library. * Refactor * Enhance env test * Aria label and test ids * Additional e2e test that checks that an action actually wrote a file. Collect and surface action run errors in e2e tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e2e test aerie-action api behaviors using a test mode of the aerie-actions-demo and update aerie-actions library to latest.