Skip to content

Fix 'Send to Workspace' to work with new Sequencing Workspaces#1809

Merged
dandelany merged 8 commits into
developfrom
hotfix/send-to-workspace
Jan 15, 2026
Merged

Fix 'Send to Workspace' to work with new Sequencing Workspaces#1809
dandelany merged 8 commits into
developfrom
hotfix/send-to-workspace

Conversation

@JosephVolosin
Copy link
Copy Markdown
Contributor

@JosephVolosin JosephVolosin commented Oct 16, 2025

This pull-request updates the 'Send to Workspace' feature in plan expansion to let the user create a new file in a sequencing workspace loaded with the expansion result of an expanded sequence.

Screen.Recording.2025-10-16.at.11.17.30.AM.mov

Testing

  1. Set PUBLIC_COMMAND_EXPANSION_MODE=templating in .env to enable Sequence Templating expansion
  2. Upload bananation.jar
  3. Upload command_dictionary.xml, and create a new parcel called Test with it
  4. Create a Workspace using the Test parcel
  5. From the Sequence Templates menu option, create a new Sequence Template with the following criteria:

Template Name: Test
Template Language: Text
Parcel: Test
Model: Bananation
Activity Type: BakeBananaBread

  1. Modify the content of the Sequence Template to say Test data
  2. Create a new plan with the Bananation model, any time range
  3. Insert a BakeBananaBread activity, set arguments to any values, simulate
  4. Under Expansion, create a new sequence called Test
  5. Add the BakeBananaBread activity to the Test sequence
  6. Within the Expansion panel, hover over the Test sequence and click the play/Expand Sequence button
  7. Within the Expansion panel, hover over the Test sequence and click the Send Expanded Sequence to Workspace button
  8. Select the previously created workspace and click Save
  9. Enter Test.txt for the filename and click Confirm
  10. Navigate to the workspace and confirm the file is created with the Test data content inside

Comment thread src/components/modals/ExpansionPanelModal.svelte
Copy link
Copy Markdown
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also mind adding permission checks to the workspace dropdown or submit button for if the user even has access to the workspace that they want to send the sequence to? There is a featurePermission.workspace() in utilities/permissions.ts that you can use to see if the user can upload to the selected workspace.

Copy link
Copy Markdown
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@duranb duranb added the DON'T MERGE Do Not Merge This Branch label Jan 5, 2026
Comment thread src/utilities/effects.ts Outdated
@duranb duranb removed the DON'T MERGE Do Not Merge This Branch label Jan 5, 2026
@AaronPlave AaronPlave force-pushed the hotfix/send-to-workspace branch from baea6c0 to 78155eb Compare January 13, 2026 00:45
@duranb duranb force-pushed the hotfix/send-to-workspace branch from 78155eb to bcb6630 Compare January 13, 2026 20:06
@dandelany dandelany force-pushed the hotfix/send-to-workspace branch from 6d1fccf to c1b749c Compare January 15, 2026 00:13
Copy link
Copy Markdown
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a one-line fix in 1767257 since the function signature for getWorkspaceContents changed in another merged PR. Ready to merge when tests pass!

@dandelany dandelany merged commit ff2b8c0 into develop Jan 15, 2026
5 checks passed
@dandelany dandelany deleted the hotfix/send-to-workspace branch January 15, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants