Manual Recordings: restore date time subtitle

[ulmus-scott]

Apparently removed in 5f6697e

Checklist

• contribution does not duplicate one of our existing pull requests
• contribution is in a branch rebased against master
• code compiles successfully without errors
• code follows the MythTV Coding Standards
• commits are logically organised and have good commit messages

[ulmus-scott]

I rebased onto master and did some additional cleanup.

I think an additional RecordingType that allows recording on either weekends or weekdays may be useful and make daily actually be all days:

diff --git a/mythtv/programs/mythbackend/scheduler.cpp b/mythtv/programs/mythbackend/scheduler.cpp
index 69cf223c52..bb3b2c19c9 100644
--- a/mythtv/programs/mythbackend/scheduler.cpp
+++ b/mythtv/programs/mythbackend/scheduler.cpp
@@ -3767,7 +3767,14 @@ void Scheduler::UpdateManuals(uint recordid)
     case kDailyRecord:
         for (int i = 0; i < daysInWeek * weeksToSchedule; i++)
         {
-            if (startDate.dayOfWeek() < 6 && startDate.addDays(offset + i).dayOfWeek() >= 6)
+            startList.push_back(QDateTime(startDate.addDays(offset + i), startTime, Qt::LocalTime).toUTC());
+        }
+        break;
+    case kWeekdayWeekendRecord:
+        for (int i = 0; i < daysInWeek * weeksToSchedule; i++)
+        {
+            if ((startDate.dayOfWeek() <  6 && startDate.addDays(offset + i).dayOfWeek() >= 6) ||
+                (startDate.dayOfWeek() >= 6 && startDate.addDays(offset + i).dayOfWeek() <  6))
             {
                 continue;
             }

but I'm not sure what changes would be required elsewhere.

[bennettpeter]

David Engel should review anything that affects scheduler

[gigem]

I'm deferring to John on this one as he made the change to remove it. As I understand it, the API allows the user to set a desired subtitle and description. Mythfrontend does not. A work around might be to add the date to program.subtitle only when neither record.subtitle nor record.description are set.

[ulmus-scott]

@jpoet's change sets an empty description to the date; however, the ProgramInfo constructor mythfrontend uses sets the description equal to the title, so that is never seen if using only the frontend.

mythtv/mythtv/libs/libmythbase/programinfo.cpp

Lines 827 to 828 in 3d3a2cc

	m_description = m_title =
	QString("%1 (%2)").arg(m_title, QObject::tr("Manual Record"));