jsonrpc-alt: gate address balance object fallback#26195
Open
Rifvckzie13 wants to merge 1 commit intoMystenLabs:mainfrom
Open
jsonrpc-alt: gate address balance object fallback#26195Rifvckzie13 wants to merge 1 commit intoMystenLabs:mainfrom
Rifvckzie13 wants to merge 1 commit intoMystenLabs:mainfrom
Conversation
Rifvckzie13
requested review from
amnn,
emmazzz,
evan-wall-mysten,
henryachen,
nickvikeras,
tpham-mysten and
wlmyng
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Rifvckzie13
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
approved these changes
Apr 10, 2026
Contributor
amnn
left a comment
amnn
left a comment
There was a problem hiding this comment.
Thanks very much for this fix @Rifvckzie13, it looks good to me -- out of interest, what do you use jsonrpc-alt for?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gate the masked address-balance object fallback on
enable_coin_reservation_obj_refssosui_getObjectandsui_multiGetObjectsmatch the existingsuix_getCoinsbehavior when coin reservations are disabled.Add a regression test that boots the alt stack with address balances enabled but coin reservations disabled, then verifies masked IDs stay unresolved across
getCoins,getObject, andmultiGetObjects.Test plan
rustfmt --check crates/sui-indexer-alt-jsonrpc/src/data/address_balance_coins.rs crates/sui-indexer-alt-e2e-tests/tests/jsonrpc_address_balance_coin_tests.rs
CARGO_HOME=/tmp/cargo-home-sui-gate
CARGO_TARGET_DIR=/Users/zhenggenglin/Documents/project/sui/target
cargo test -p sui-indexer-alt-e2e-tests --test jsonrpc_address_balance_coin_tests --no-run --offline
Release notes