Conversation
## Description Addressing some post-land nits from #26116. The main one is that we should not refer to `anyhow::Result` in an unguarded way, as it leads to confusion about the error type, and we should not re-export types that are accessible through other means (i.e. their module is not private to the crate), as it leads to inconsistencies when the language server tries to resolve them. ## Test plan CI
amnn
requested review from
emmazzz,
evan-wall-mysten,
henryachen,
nickvikeras,
tpham-mysten and
wlmyng
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
8 tasks
evan-wall-mysten
added a commit
that referenced
this pull request
Apr 10, 2026
…26198) ## Description **Commit 1:** Adds back #26096 and #26116 which were reverted in #26188. **Commit 2:** Specify `timeout` along with `connect_timeout` when creating the gRPC client. * `connect_timeout` only bounds the TCP/TLS handshake - the low-level socket connect. Once the TCP connection is established, `connect_timeout` has no further effect. The `subscribe_checkpoints` RPC is a separate HTTP/2 request sent over the already-established connection, so it's not covered by that setting. If a server accepts TCP, but stalls before sending response headers, the client hangs the indefinitely. * `timeout` is the counterpart that bounds individual RPC calls on the channel. **Commit 3:** Include changes from #26182. ## Test plan Added new unit test to prove indexer does not hang during startup when streaming hangs. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addressing some post-land nits from #26116. The main one is that we should not refer to
anyhow::Resultin an unguarded way, as it leads to confusion about the error type, and we should not re-export types that are accessible through other means (i.e. their module is not private to the crate), as it leads to inconsistencies when the language server tries to resolve them.Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.