Skip to content

Add active polling to recursive mode#76

Closed
Mygod wants to merge 8 commits intomainfrom
active-poll
Closed

Add active polling to recursive mode#76
Mygod wants to merge 8 commits intomainfrom
active-poll

Conversation

@Mygod
Copy link
Owner

@Mygod Mygod commented Feb 21, 2026

This fixes poor download performance.

@Mygod Mygod requested a review from Copilot February 21, 2026 01:44
@Mygod Mygod added the enhancement New feature or request label Feb 21, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an active polling mechanism to improve download performance when there are open streams but no data ready to send. The feature introduces a configurable cap on the polling backoff interval and implements exponential backoff to avoid excessive polling while maintaining responsiveness.

Changes:

  • Added active_poll_cap_ms configuration parameter with validation (minimum value of 1)
  • Implemented active polling logic with exponential backoff that triggers when streams exist but none are ready
  • Fixed polls_sent counter to only increment after successful UDP send operations (necessary for accurate backoff calculation)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/slipstream-ffi/src/lib.rs Added active_poll_cap_ms field to ClientConfig struct
crates/slipstream-client/src/runtime.rs Implemented active polling logic with helper functions, exponential backoff, and integration into main event loop
crates/slipstream-client/src/main.rs Added CLI argument, SIP003 option parsing, validation, and tests for active_poll_cap_ms
crates/slipstream-client/src/dns/poll.rs Moved polls_sent counter increment to after successful UDP send for accurate tracking

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Mygod Mygod requested a review from Copilot February 21, 2026 03:57
@Mygod
Copy link
Owner Author

Mygod commented Feb 21, 2026

@codex review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Mygod Mygod closed this Feb 21, 2026
@Mygod
Copy link
Owner Author

Mygod commented Feb 21, 2026

Closing due to insufficient consideration of RTT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants