Added an event indicating when an expired timer is stopped. #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisgesling
reviewed
Sep 27, 2021
Contributor
krisgesling
left a comment
krisgesling
left a comment
There was a problem hiding this comment.
Yeah love it - given the Skill currently plays the beep sound we can be pretty confident that if the Skill doesn't think a timer has expired then it shouldn't be playing the beep anymore.
chrisveilleux
force-pushed
the
bugfix/failing-vk-tests
branch
from
2f8a1a1 to
1c57bbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The VoightKampff tests for this skill were producing false positives in the tests that check for stopping an expired timer. Added a
timer.stopped-expiredevent that is emitted when any expired timer is stopped. The tests now check for this event rather than the existence of a beeping sound to determine if an expired timer was successfully stopped.During testing of this PR, it was determined that several of the "stop" commands that have been passing should not be. These are words that are not included in the vocabulary of the Stop Skill (a.k.a. System Skill). They have been marked as "expected fail" temporarily.
This PR is dependent on Mycroft Core PR 3002.
Type of PR
If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR.
Testing
Run the VK tests with a version of core that includes the changes in the aforementioned PR.
Documentation
Docstrings have been included in all the new testing code.