This repository was archived by the owner on Jun 6, 2020. It is now read-only.
Browser versions, device brands and models parsing #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after replacing placeholders
instead of main memory
Closed
saving processor time
also it led to segfault on reload routine
|
Is anyone going to merge this? |
|
FWIW I never had luck with this repo-- they've basically abandoned it. I made https://github.com/clarfon/nginx-uaparser-module as an alternative if you want to try your luck with that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to detect browser and OS versions, and also device brands and models. It also changes the way JSON DB is generated (it now has additional regexes arrays for brands and models).