Skip to content

temporary workaround for suggestion box RN74 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrRefactor merged 2 commits into from
Aug 7, 2024
Merged

temporary workaround for suggestion box RN74 #1

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2523246
temporary workaround for suggestion box RN74
perunt Aug 6, 2024
3200499
typo
perunt Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion ...pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import Parser from '@libs/Parser';
import ReportActionComposeFocusManager from '@libs/ReportActionComposeFocusManager';
import * as ReportActionsUtils from '@libs/ReportActionsUtils';
import * as ReportUtils from '@libs/ReportUtils';
import StatusBar from '@libs/StatusBar';
import updateMultilineInputRange from '@libs/updateMultilineInputRange';
import willBlurTextInputOnTapOutsideFunc from '@libs/willBlurTextInputOnTapOutside';
import getCursorPosition from '@pages/home/report/ReportActionCompose/getCursorPosition';
Expand Down Expand Up @@ -186,6 +187,7 @@ type SwitchToCurrentReportProps = {
const {RNTextInputReset} = NativeModules;

const isIOSNative = getPlatform() === CONST.PLATFORM.IOS;
const isAndroidNative = getPlatform() === CONST.PLATFORM.IOS;

/**
* Broadcast that the user is typing. Debounced to limit how often we publish client events.
Expand Down Expand Up @@ -706,9 +708,26 @@ function ComposerWithSuggestions(
onValueChange(value);
}, [onValueChange, value]);

const getScrollValue = () => {
if (!textInputRef?.current || !isAndroidNative) {
return;
}
textInputRef?.current.measure((x, y, width, height, pageX, pageY) => {
textInputRef?.current?.measureInWindow((winX, winY) => {
const scrollValue = pageY - winY;

if (scrollValue - (StatusBar?.currentHeight ?? 0) <= 1) {
mobileInputScrollPosition.current = 0;
}
});
});
};

const onLayout = useCallback(
(e: LayoutChangeEvent) => {
const composerLayoutHeight = e.nativeEvent.layout.height;
getScrollValue(); // This is a workaround to fix suggestion box positioning on android devices, to be removed with react-native 0.75

if (composerHeight === composerLayoutHeight) {
return;
}
Expand Down Expand Up @@ -751,7 +770,7 @@ function ComposerWithSuggestions(
measureParentContainer((x, y, width, height) => {
callback({
x,
y,
y: Number(y) + (StatusBar?.currentHeight ?? 0), // This is a workaround to fix suggestion box positioning on android devices, to be removed with react-native 0.75
width,
height,
scrollValue,
Expand Down