Feature for Release - MongoDB Atlas Configuration + API GW FIX Trigger #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanPitz
requested review from
barvarmoveo,
omrip2 and
orenrosenmann
as code owners
leona-moveohls
approved these changes
Aug 20, 2024
Author
|
<3
…On Tue, Aug 20, 2024 at 11:18 AM leon avshalom ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#935 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5I2VYYCSIO6MV22VH5BQQ3ZSL3XFAVCNFSM6AAAAABMZLBMAOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBXGI4TGMJYGU>
.
You are receiving this because you authored the thread.Message ID:
<MoveoTech/terraform-aws-rest-api-architecture/pull/935/review/2247293185@
github.com>
--
*Jonathan Sabatani*
*DevSecOps Engineer*
*Moveo.Group* <http://Moveo.Group>
*054-2040376*
|
JonathanPitz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATLAS:
Added a couple of Variables, so a user can determine whether the compute auto-scaling is enabled or not.
When setting it to true, it will initiate 3 more variable that will result in autoscaling enabled-
M10 < ComputePower < M20.
those variables could be changed as well.
API GW:
Changed the trigger for deplyment to a change in the json body of the REST, based on the official resource documantation here - LINK
Also added the alternative for a redeployment on every Terraform Apply via a timestamp function.
This var is false by default, so the more traditional trigger will be initiated alone in most cases.