feat(http): enable trust_env in creating aiohttp.ClientSession#1236
Open
CyCle1024 wants to merge 2 commits intoMoonshotAI:mainfrom
Open
feat(http): enable trust_env in creating aiohttp.ClientSession#1236CyCle1024 wants to merge 2 commits intoMoonshotAI:mainfrom
CyCle1024 wants to merge 2 commits intoMoonshotAI:mainfrom
Conversation
CyCle1024
changed the title
CyCle1024
force-pushed
the
fix_https_proxy_login
branch
from
b47238a to
5336664
Compare
This was referenced Feb 26, 2026
Author
|
@RealKai42 please approve workflows, this PR is waiting for reviewing. |
This was referenced Mar 1, 2026
CyCle1024
force-pushed
the
fix_https_proxy_login
branch
from
5336664 to
1c1e26f
Compare
CyCle1024
changed the title
CyCle1024
force-pushed
the
fix_https_proxy_login
branch
2 times, most recently
from
917247f to
195525e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CyCle1024
force-pushed
the
fix_https_proxy_login
branch
from
195525e to
fd43808
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
CyCle1024
force-pushed
the
fix_https_proxy_login
branch
2 times, most recently
from
8e6a27a to
8bdddfd
Compare
5 tasks
CyCle1024
force-pushed
the
fix_https_proxy_login
branch
from
8bdddfd to
df651b9
Compare
CyCle1024
force-pushed
the
fix_https_proxy_login
branch
from
df651b9 to
2ae1af7
Compare
This makes the aiohttp client session respect env like `https_proxy`, `http_proxy` and so on.
CyCle1024
force-pushed
the
fix_https_proxy_login
branch
from
2ae1af7 to
b7ed408
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #1234
Description
Add parameter
trust_env=Truewhen creatingaiohttp.ClientSessioninsrc/kimi_cli/utils/aiohttp.py.This would make aiohttp.ClientSession respect environment variable such as
https_proxy,HTTPS_PROXYand so on.By default,
trust_envis setFalsein__init__funcion ofaiohttp.ClientSession.Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.