-
Notifications
You must be signed in to change notification settings - Fork 52
Perf/convert custom to built in for parquet metadata deserialization #2191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thuongle2210
wants to merge
20
commits into
Mooncake-Labs:main
Choose a base branch
from
thuongle2210:perf/convert-custom-to-built-in-for-parquet-metadata-deserialization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Perf/convert custom to built in for parquet metadata deserialization #2191
thuongle2210
wants to merge
20
commits into
Mooncake-Labs:main
from
thuongle2210:perf/convert-custom-to-built-in-for-parquet-metadata-deserialization
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release: bump toolchain chanel version
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 9. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Author
|
Hi @dentiny, could you pls help me review this PR? |
|
This PR has been inactive for 14 days and is now marked as stale. If this is still being worked on, please comment to keep it open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Briefly explain what this PR does.
Inspired from: https://arrow.apache.org/blog/2025/10/23/rust-parquet-metadata/
My benchmark implementation: https://github.com/thuongle2210/parquet_decoding
Improvement: 1.84 times faster with Parquet version 56.0.0, and approximately 3 times faster with Parquet version 57.0.0.
This is due to dependencies on other libraries (for example, the latest version of deltalake matches with Parquet 56). Therefore, I keep using Parquet 56.0.0
Related Issues
links to related issues: #2192
Changes
Checklist