docs: vars for tag database and schema#55
Merged
JFrackson merged 1 commit intoMontreal-Analytics:masterfrom Feb 6, 2024
Merged
docs: vars for tag database and schema#55JFrackson merged 1 commit intoMontreal-Analytics:masterfrom
JFrackson merged 1 commit intoMontreal-Analytics:masterfrom
Conversation
Improved docs regarding tag database and schema
JFrackson
approved these changes
Feb 6, 2024
Contributor
JFrackson
left a comment
JFrackson
left a comment
There was a problem hiding this comment.
lgtm! Good addition for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the
README.md, to make it explicit that the variables should be insidevars.