fix: correct cache key#54
Merged
JFrackson merged 1 commit intoMontreal-Analytics:masterfrom Feb 6, 2024
Merged
Conversation
This package uses a cache to check if a tag exists or if it needs to be created. Once a tag is created it is added to the cache. This did not work properly, since the different keys were used at cache lookup (tag name) and add to cache (fully qualified tag name).
JFrackson
approved these changes
Feb 6, 2024
Contributor
JFrackson
left a comment
JFrackson
left a comment
There was a problem hiding this comment.
good catch! Thanks for the fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package uses a cache to check if a tag exists or if it needs to be created. Once a tag is created it is added to the cache. This did not work properly, since the different keys were used at cache lookup (tag name) and add to cache (fully qualified tag name).
I noticed this in a DBT project where multiple models, in the same schema, are creating table tags independently of each other. If the first model creates the tag, the next model would also try to create it leading to this error:
09:23:58 Tag already exists: GOLD.DBT_CV_DEV_VALIDATIONS.DBT_VALIDATION_KEY