Added a test demonstrating the behavior in issue #938 #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

eli-b wants to merge 5 commits into MongoEngine:master from eli-b:issue938

Contributor

eli-b commented Apr 10, 2015

landscape-bot commented Apr 10, 2015

Code quality remained the same when pulling 5756e8e on eli-b:issue938 into 19dc312 on MongoEngine:master.

coveralls commented Apr 10, 2015

Coverage remained the same at 73.03% when pulling 2f0b371 on eli-b:issue938 into 19dc312 on MongoEngine:master.

landscape-bot commented Apr 10, 2015

Code quality remained the same when pulling 2f0b371 on eli-b:issue938 into 19dc312 on MongoEngine:master.

landscape-bot commented Apr 10, 2015

Code quality remained the same when pulling 4ae1d8f on eli-b:issue938 into 19dc312 on MongoEngine:master.

eli-b added 3 commits

April 10, 2015 15:27


          Added a test demonstrating the behavior in issue MongoEngine#938

5756e8e


          Better name for test

2f0b371


          Added docstring

4ae1d8f

coveralls commented Apr 10, 2015

Coverage remained the same at 73.03% when pulling 4ae1d8f on eli-b:issue938 into 19dc312 on MongoEngine:master.

coveralls commented Apr 10, 2015

Coverage remained the same at 73.03% when pulling 4ae1d8f on eli-b:issue938 into 19dc312 on MongoEngine:master.

landscape-bot commented Apr 10, 2015

Code quality remained the same when pulling 8a26e91 on eli-b:issue938 into 19dc312 on MongoEngine:master.


          Python 2.6 doesn't have assertIsNone

8a26e91

coveralls commented Apr 10, 2015

Coverage decreased (-0.02%) to 73.01% when pulling 8a26e91 on eli-b:issue938 into 19dc312 on MongoEngine:master.

6 similar comments

coveralls commented Apr 10, 2015

Coverage decreased (-0.02%) to 73.01% when pulling 8a26e91 on eli-b:issue938 into 19dc312 on MongoEngine:master.

coveralls commented Apr 10, 2015

Coverage decreased (-0.02%) to 73.01% when pulling 8a26e91 on eli-b:issue938 into 19dc312 on MongoEngine:master.

coveralls commented Apr 10, 2015

Coverage decreased (-0.02%) to 73.01% when pulling 8a26e91 on eli-b:issue938 into 19dc312 on MongoEngine:master.

coveralls commented Apr 10, 2015

Coverage decreased (-0.02%) to 73.01% when pulling 8a26e91 on eli-b:issue938 into 19dc312 on MongoEngine:master.

coveralls commented Apr 10, 2015

Coverage decreased (-0.02%) to 73.01% when pulling 8a26e91 on eli-b:issue938 into 19dc312 on MongoEngine:master.

coveralls commented Apr 10, 2015

Coverage decreased (-0.02%) to 73.01% when pulling 8a26e91 on eli-b:issue938 into 19dc312 on MongoEngine:master.

coveralls commented Apr 10, 2015

Coverage remained the same at 73.03% when pulling 8a26e91 on eli-b:issue938 into 19dc312 on MongoEngine:master.

Contributor Author

eli-b commented Apr 11, 2015

The test I added now passes on all tested configurations, I think the failed check is unrelated.


          Failing the test instead of demonstrating the current behavior

7f90cf9

landscape-bot commented Apr 25, 2015

Code quality remained the same when pulling 7f90cf9 on eli-b:issue938 into 19dc312 on MongoEngine:master.

coveralls commented Apr 25, 2015

Coverage increased (+0.0%) to 73.03% when pulling 7f90cf9 on eli-b:issue938 into 19dc312 on MongoEngine:master.

Contributor Author

eli-b commented Apr 26, 2015

Already have, see above: "Failing the test instead of demonstrating the current behavior".

MRigal assigned DavidBord

MRigal added the In Progress label

landscape-bot commented May 6, 2015

Repository health decreased by 0.21% when pulling 7f90cf9 on eli-b:issue938 into 7f442f7 on MongoEngine:master.

35 new problems were found (including 3 errors and 29 code smells).
7 problems were fixed (including 0 errors and 7 code smells).

MRigal modified the milestone: 0.10.1

eli-b closed this

eli-b deleted the issue938 branch

July 17, 2015 14:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet