Delete cascade cycle issue

[emilecaron]

[emilecaron]

#1043

[landscape-bot]

Code quality remained the same when pulling c3da07c on emilecaron:master into c6151e3 on MongoEngine:master.

[MRigal]

Hi @emilecaron
Thanks for your PR. However there are some valid tests failing, like test_reverse_delete_rule_cascade_self_referencing()
Have you tested it locally? Could you have a look?

[emilecaron]

Yerp i'll look into it

[landscape-bot]

Repository health decreased by 0.01% when pulling 9b7fe9a on emilecaron:master into c6151e3 on MongoEngine:master.

• 1 new problem was found (including 0 errors and 1 code smell).
• No problems were fixed.

[emilecaron]

Ok it's actually not that simple. I'll look into it later.

[landscape-bot]

Code quality remained the same when pulling 56a2e07 on emilecaron:master into c6151e3 on MongoEngine:master.

[MRigal]

Nice job @emilecaron ! The solution also seems very reasonable. Would you eventually like to add a test combining over three level reference to self and to another class? Just to make the code base more stable against possible future changes. Then, I'll merge it!

[MRigal]

Ah yes, and also please add a line to the changelog to present your fix and if you want, add yourself to the AUTHORS list :-)

[landscape-bot]

Code quality remained the same when pulling 4525eb4 on emilecaron:master into c6151e3 on MongoEngine:master.

[MRigal]

Thanks @emilecaron , I've modified the place for the change, since 0.10.0 is already out and added a fancier test.