Open
Conversation
* add folder param to upload_multiple_files_to_s3 and get_user_images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Morpheus API tests. All endpoints covered.
2 of the tests fail at the moment, both for the same reason:
test_upload_multiple_files_to_s3reason="Folder missing. Need to specify 'collections' or 'avatars'"test_get_user_imagesreason="Folder missing. Checks in /[email protected], images are in /collections/[email protected]"These endpoints probably have to be fixed.
And one test has an unhandled exception which propagates to test code, due to how pytest + htmx starts a FastAPI asgi app:
test_get_artworks_by_collection_id_not_foundI marked that one as xfail.
Also I added
mototo mock calls to S3.TODO issue, please read:
Due to it being quite complicated to mock
diffusers, I settled on using a minimal model from huggingface.It unfortunately gets downloaded.
I considered including it into the repository, but the code does not have any LICENSE. I raised an issue with HF for this.
Alternatively we can download and cache it in CI, but not include in the repo. Would that be an acceptable approach?