[Feat] Mooncake & Mooncake|Posix#945
Open
UESTC-AHao wants to merge 1 commit intoModelEngine-Group:developfrom
Open
[Feat] Mooncake & Mooncake|Posix#945UESTC-AHao wants to merge 1 commit intoModelEngine-Group:developfrom
UESTC-AHao wants to merge 1 commit intoModelEngine-Group:developfrom
Conversation
UESTC-AHao
requested review from
FangRun2,
Infinite666,
Tarrei,
chinesezyc,
harrisonyhq,
mag1c-h,
qyh111 and
ygwpz
as code owners
UESTC-AHao
force-pushed
the
dev_fh_mooncake
branch
6 times, most recently
from
5e3d768 to
b6df4c9
Compare
UESTC-AHao
force-pushed
the
dev_fh_mooncake
branch
from
b6df4c9 to
716c6b3
Compare
sumingZero
reviewed
May 6, 2026
| master_server_address: "127.0.0.1:50088" | ||
| metadata_server: "P2PHANDSHAKE" | ||
| protocol: "ascend" | ||
| global_segment_size: 32212254720 |
Contributor
There was a problem hiding this comment.
Should we explain the meaning of these parameters
sumingZero
reviewed
May 6, 2026
| return self.store_.Check(task.task_id) | ||
|
|
||
| def register_memory(self, base_addr: int, total_size: int) -> None: | ||
| self.store_.RegisterMemory(base_addr, total_size) |
Contributor
There was a problem hiding this comment.
Should the return value of RegisterMemory be validated
sumingZero
reviewed
May 6, 2026
| * @param total_size Total size of the memory region in bytes. | ||
| * @return Status::OK on success, error code on failure. | ||
| */ | ||
| virtual Status RegisterMemory(void* base_addr, size_t total_size) = 0; |
Contributor
There was a problem hiding this comment.
If RegisterMemory is Mooncake-specific operation, should it be handled internally within MooncakeStore rather than being added as a public interface in StoreV1 base class? The current design forces all other store implementations to provide empty stub methods, violating Interface Segregation Principle.
yuanzhg078
reviewed
May 6, 2026
| metadata_server, | ||
| protocol, | ||
| global_segment_size, | ||
| replica_num, |
Contributor
There was a problem hiding this comment.
create_mooncake_store() is called with an extra argument worker_num, but its function signature does not define worker_num
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
UCM + Mooncake & Mooncake|Posix (Ascend 0.18.0)
Modifications
unified-cache-management\examples\ucm_mooncake_config.yaml
Test