Skip to content

Conversation

@mikeaaaaaa
Copy link
Contributor

@mikeaaaaaa mikeaaaaaa commented Jun 21, 2025

🔗 相关问题 / Related Issue

Issue 链接 / Issue Link: #285

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改(如错别字),不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

📋 主要变更 / Brief Changelog

  • 增加了fit框架对于nacos的支持
  • 增加fit框架使用nacos插件的用例

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

  1. 使用fit-example下的第八个测试用例进行测试

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更(微小变更如错别字除外)/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue,没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • 当存在跨模块依赖时,我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 基础检查通过:mvn -B clean package -Dmaven.test.skip=true,elsa README 中的编译检查 / Basic checks pass
  • 单元测试通过:mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更,我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes


审查者注意事项 / Reviewer Notes:

@CodeCasterX CodeCasterX self-assigned this Jun 22, 2025
@CodeCasterX CodeCasterX added in: fit Issues in FIT modules type: feature A general feature labels Jun 22, 2025
@CodeCasterX CodeCasterX added this to the 3.6.x milestone Jun 22, 2025
@CodeCasterX CodeCasterX modified the milestones: 3.6.x, 3.6.0 Jul 14, 2025
@CodeCasterX CodeCasterX linked an issue Jul 15, 2025 that may be closed by this pull request
CodeCasterX
CodeCasterX previously approved these changes Aug 1, 2025
@mikeaaaaaa mikeaaaaaa changed the title Fit enhancement nacos Fit enhancement nacos registry plugin Aug 6, 2025
@CodeCasterX CodeCasterX changed the title Fit enhancement nacos registry plugin Add nacos registry plugin Aug 6, 2025
@mikeaaaaaa mikeaaaaaa force-pushed the fit-enhancement-nacos branch from 5fdcacb to c2eb997 Compare August 6, 2025 11:08
@CodeCasterX CodeCasterX merged commit b96fe46 into ModelEngine-Group:main Aug 8, 2025
1 check passed
@github-project-automation github-project-automation bot moved this to Done in OSPP 2025 Aug 8, 2025
@CodeCasterX CodeCasterX linked an issue Sep 5, 2025 that may be closed by this pull request
4 tasks
@CodeCasterX CodeCasterX linked an issue Sep 5, 2025 that may be closed by this pull request
4 tasks
surpercodehang pushed a commit that referenced this pull request Oct 10, 2025
* [fit] 增加fit-server-coordination-nacos内置插件

* [fit] 增加Registry port、IP信息的动态获取

* [fit] 修改nacos默认配置,最简单化

* [fit] 修改nacos notify函数死循环bug

* [fit] 增加nacos的使用example以及一些类的注释

* [fit] 修改example8中的nacos地址为本地地址

* [fit] 修改example8中的nacos地址为本地地址

* [fit] 修改文件的格式问题以及增加必要的注释

* [fit] 毫秒时间类型设置为long

* [fit] 修改格式错误以及方法抽取

* [fit] 修改注释错误以及方法抽取

* [fit] 统一修改和registry相关的fitable-id和genericable-id

* [fit] 统一修改和registry相关的fitable-id和genericable-id; 增加Notify接口; 修改注释为英文; 支持用户对nacos配置

* [fit] 增加缺失的 this.

* [fit] 为 NacosConfig 增加详细注释; 修改heartBeat错误拼写; 修改部分未修改的fitableId

* [fit] 修改某个fitableId

* [fit] 统一内存版注册中心和nacos注册中心的配置方式

* [fit] 增加注册中心连接模式,默认DIRECT模式,还可设置为PROXY模式

* [fit] 删除不必要的配置信息

* [fit] matata.registry.nacos配置改从插件中读取

* [fit] 修改格式错误

* [fit] 修改代码格式错误

* [fit] 修改代码格式错误,增加this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: fit Issues in FIT modules type: feature A general feature

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

fit java 版支持接入 Nacos 注册中心

3 participants