Skip to content

deviceID gets sent from the connector instead of pin number#346

Merged
DocMoebiuz merged 1 commit intoMobiFlight:mainfrom
elral:output_device_id
Jan 6, 2025
Merged

deviceID gets sent from the connector instead of pin number#346
DocMoebiuz merged 1 commit intoMobiFlight:mainfrom
elral:output_device_id

Conversation

@elral
Copy link
Collaborator

@elral elral commented Dec 23, 2024

Description of changes

Once the PR 1886 from the connector is merged the command for setting an output will be slightly different. Instead of sending a pin number the deviceID is send like for all other devices. This is for harmaonization and possible future extensions.

Fixes #345

@elral elral requested a review from DocMoebiuz as a code owner December 23, 2024 06:19
@github-actions
Copy link

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

@github-actions
Copy link

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

@github-actions
Copy link

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

@github-actions
Copy link

github-actions bot commented Jan 6, 2025

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

@elral elral force-pushed the output_device_id branch from 9c87185 to b86c837 Compare January 6, 2025 20:30
@github-actions
Copy link

github-actions bot commented Jan 6, 2025

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

@elral elral force-pushed the output_device_id branch from b86c837 to e55d65d Compare January 6, 2025 20:33
@github-actions
Copy link

github-actions bot commented Jan 6, 2025

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

@DocMoebiuz DocMoebiuz merged commit 6fde2f3 into MobiFlight:main Jan 6, 2025
@DocMoebiuz DocMoebiuz added the enhancement New feature or request label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command for outputs have pin number and not deviceID

2 participants