Merged
Conversation
|
Board and firmware folder for this pull request: |
|
Board and firmware folder for this pull request: |
|
Board and firmware folder for this pull request: |
|
Board and firmware folder for this pull request: |
DocMoebiuz
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
When introducing the UniqueID for the Pico the function to generate a new serial number, in this case according the AVR style, was kept. There is no reason to have this function as the UniqueID is always different between each Pico.
This is different to the AVR boards. They do not have a UniqueID and therefore a SN gets generated on first start up. Seldom the same SN can get generated like an already existing board. In this case the function to regenerate a SN is required.
The function to regenerate a SN for the Pico is deleted. But it is still checked if it was used before and a SN according the old style is used. In this case this SN will still be used to not get orphaned boards. If the user regenerates again a new SN, the UniqueID will be used and it gets markes in the EEPROM accordingly.
Furthermore setting the first byte of the config to
0x00for new boards is deleted. This was discussed before but not implemented. It's deleted to be sure that a config get's never deleted from the FW itself.