No fixed max. shifters per chain#292
Merged
DocMoebiuz merged 4 commits intoMobiFlight:mainfrom Dec 25, 2023
Merged
Conversation
|
Firmware for this pull request: |
|
Firmware for this pull request: |
DocMoebiuz
approved these changes
Dec 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
For input and output shifter the statically initialized buffer is replaced by a dynamcally initialization on runtime with the size of chained 8bit shifter. The required memory will be in the device buffer as all deiveces.
This allows to use more than four 8bit shifter in one chain.
See also MobiFlight/MobiFlight-Connector#1323
Additionally small code clean up is done.
Fixes #291