Two pins get set on Pico Board#285
Merged
DocMoebiuz merged 4 commits intoMobiFlight:mainfrom Nov 23, 2023
Merged
Conversation
|
Firmware for this pull request: |
|
Firmware for this pull request: |
This was referenced Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
On the Pico two pins get set at the same time if both pins are configured as output and the difference of the pin numbers are 16.
Moving the initialization of the pin from the class
MFOutput()to the function which calls the initializationOutput::Add()solves this issue.For now it is unclear why this change fixes it. More investigation has to be done.
The change is only done for the Pico and not for the other boards.
Additionally changes are implemented to fix issue #284 to avoid merge errors when both PR gets merged. An additional comment will be given in the upcoming PR.
Fixes #283