MOBIFLIGHT_TYPE is already defined in MFBoards.h#282
Merged
DocMoebiuz merged 1 commit intoMobiFlight:mainfrom Nov 18, 2023
Merged
MOBIFLIGHT_TYPE is already defined in MFBoards.h#282DocMoebiuz merged 1 commit intoMobiFlight:mainfrom
DocMoebiuz merged 1 commit intoMobiFlight:mainfrom
Conversation
|
Firmware for this pull request: |
DocMoebiuz
approved these changes
Nov 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
With PR #258 custom devices were added. Accidently
'-DMOBIFLIGHT_TYPE="MobiFlight Micro"'was added to theplatformio.inifile, but as it is a standard definition it belongs to MFBoards.h``where it is still part of this file. So no need to do it inplatformio.ini.For custom devices this definition is still required to have it in the custom ini file to override the standard type.