Merged
Conversation
|
Firmware for this pull request: |
|
Firmware for this pull request: |
|
Firmware for this pull request: |
DocMoebiuz
approved these changes
Oct 21, 2023
Collaborator
DocMoebiuz
left a comment
DocMoebiuz
left a comment
There was a problem hiding this comment.
Looking good. Thanks!
DocMoebiuz
requested changes
Oct 21, 2023
Collaborator
DocMoebiuz
left a comment
DocMoebiuz
left a comment
There was a problem hiding this comment.
There is one byte that we want to change to uint8_t so that it is perfect.
|
Firmware for this pull request: |
|
Firmware for this pull request: |
|
Firmware for this pull request: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I went a couple of times through all functions, not much I found to optimize the Flash usage.
Overall this results in 1690 bytes less of Flash usage and 43 bytes less of RAM usage.
One important remark
I have deleted the usage of UniqueID for all AVR Boards. There was only less time where this was used. If a board was initialized in this timeframe, a new serial number will be generated with this change. I guess there are only verly less user who are affected, not to say no user is affected.
I vote to take now the chance to get rid of these serial numbers to not deal with them in the future.
If we should still keep them, I will add again the detection but without using the sprintf() function to take care of the huge flash saving.
@MobiFlight-Admin @neilenns @GioCC may I ask you to comment on this and to add ideas/changes for further reducing of Flash/RAM usage.