Remove unused temp variable#246
Remove unused temp variable#246DocMoebiuz merged 2 commits intoMobiFlight:mainfrom neilenns:issue243-unused-variable-removal
Conversation
|
Firmware for this pull request: |
src/Config.cpp
Outdated
| while (MFeeprom.read_byte(addreeprom++) != 0x00) { | ||
| configLength++; | ||
| if (addreeprom > length) // abort if EEPROM size will be exceeded | ||
| if (addreeprom > length) // abort if EEPROM size will be exceeded |
There was a problem hiding this comment.
comment alignment. probably due to auto formatting rule.
This comment is also not necessary because it's obvious what is happening.
if length was called eepromLength it would be even more clear.
In general I propose to put comments above the line instead of behind.
There was a problem hiding this comment.
Do you want me to remove the comment as part of this PR? I was only trying to remove the temp variable, I didn't bother touching anything else.
There was a problem hiding this comment.
we can remove it - thanks
|
Firmware for this pull request: |
DocMoebiuz
left a comment
DocMoebiuz
left a comment
There was a problem hiding this comment.
I was not aware of the habit to have comments on end of line which makes our syntax formatter format this file every where. I don't like the long lines either, I will discuss it on #development
3 participants
Fixes #245
Removes the unused
tempvariable. The variable was introduced here.