Conversation
|
Firmware for this pull request: |
|
YES!!!!!!!!!!!!!!!!!!!!!!!!!!!! |
| @@ -0,0 +1,203 @@ | |||
| { | |||
There was a problem hiding this comment.
We haven't checked the .board.json file into this github repo for any of the amtel platforms so this should probably be excluded from this PR.
There was a problem hiding this comment.
Ups, you are rigth. Was the best location for me during delelpment.
I will delete it.
platformio.ini
Outdated
| lib_deps = | ||
| ${env.lib_deps} | ||
| ${env.lib_deps} | ||
| arduino-libraries/Servo @ 1.1.8 |
There was a problem hiding this comment.
Instead of putting the arduino library in each arduino env, how about creating a new lib_amtel_deps section then including that as ${env.lib_amtel_deps}?
There was a problem hiding this comment.
Ah, very good idea. I will change this.
There was a problem hiding this comment.
Maybe pair it with a lib_rp2040_deps too, even though there's just one rp2040 platform?
There was a problem hiding this comment.
Hmhm, there are no additional libs for the Pico.
neilenns
left a comment
neilenns
left a comment
There was a problem hiding this comment.
So exciting! Two minor suggestions. Looks great!
|
Firmware for this pull request: |
|
Firmware for this pull request: |
neilenns
left a comment
neilenns
left a comment
There was a problem hiding this comment.
It's happening!!! YES!!!
|
Firmware for this pull request: |
|
Firmware for this pull request: |
DocMoebiuz
left a comment
DocMoebiuz
left a comment
There was a problem hiding this comment.
Nice! Thank You so much!
3 participants
This pull request adds the support for the Raspberry Pi Pico.
The supported board is the original board from the Raspberry Pi Foundation.
Fixes #225