Skip to content

faulty init on startup, check for available memory#227

Merged
DocMoebiuz merged 1 commit intoMobiFlight:mainfrom
elral:init_DigInMux
Jan 5, 2023
Merged

faulty init on startup, check for available memory#227
DocMoebiuz merged 1 commit intoMobiFlight:mainfrom
elral:init_DigInMux

Conversation

@elral
Copy link
Collaborator

@elral elral commented Dec 19, 2022

On startup the constructor for the digital input multiplexer is called and the status of each input gets initialized to the current status. With one of the next steps this status get be cleared again, so on startup serial messages could be generated due to status changes of the inputs.
Furthermore it is not checked like for the other devices if the digital input multiplexer fits into the device buffer.

Calling the clear() function is deleted.
Check if device fits into the device buffer is added.

Fixes #226

@elral elral requested a review from DocMoebiuz as a code owner December 19, 2022 08:47
@github-actions
Copy link

Firmware for this pull request:
Firmware.zip

Copy link
Collaborator

@DocMoebiuz DocMoebiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch.

@DocMoebiuz DocMoebiuz merged commit bd9b4a8 into MobiFlight:main Jan 5, 2023
@elral elral deleted the init_DigInMux branch January 6, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Input Multiplexer get not initialized to current status on start up

2 participants