send deviceID instead of name from input device#219

Closed

elral wants to merge 53 commits intoMobiFlight:mainfrom

elral:wo_NameBuffer

Collaborator

elral commented Nov 9, 2022 •

edited

Loading

Description of changes

All input devices will now send there deviceID (means the xth device of same type registered) to the connector instead of the name if the status has changed.
This will reduce the serial traffic and reduce the RAM consumption as the NameBuffer is not required anymore.

@GioCC will issue an additional pull request with the required changes for the input multiplexer. These changes are not part of this pull request. GioCC will also add the comment that issue 207 will be fixed, so it's not required here.

Changes in the connector are also required as the names are not send anymore.

Fixes #207

/edit: added reference to issue


          send deviceID instead of name from input device

elral requested a review from DocMoebiuz as a code owner

November 9, 2022 07:07

github-actions bot commented Nov 9, 2022

Firmware for this pull request:
Firmware.zip

GioCC added a commit to GioCC/MobiFlight-FirmwareSource that referenced this pull request


          Partial modification for issue MobiFlight#207 (to be added to PR Mobi…

8e3df07

…Flight#219)

elral added 2 commits

November 10, 2022 11:56


          add InputMultiplexer w/ deviceID instead of name

800a382


          change name into deviceID for the handler defin.

fe43697

github-actions bot commented Nov 10, 2022

Firmware for this pull request:
Firmware.zip

Contributor

GioCC commented Nov 10, 2022

@elral Sorry, I forgot that file.
The offending MuxDigInEvent typedef declaration has to be completely removed from MFMuxDriver.h, it had no business being there in the first place (as it's already in MFDigInMux.h where it belongs).


          delete double define of Mux handler

02a5808

github-actions bot commented Nov 11, 2022

Firmware for this pull request:
Firmware.zip


          deactivate config if reading from EEPROM fails

53ac8e8

github-actions bot commented Dec 6, 2022

Firmware for this pull request:
Firmware.zip

elral added 2 commits

December 6, 2022 08:03


          correct comment for variable copy_success

80b3273


          Merge branch 'wo_NameBuffer' of https://github.com/elral/MobiFlight-F…

3b19a95

…irmwareSource into wo_NameBuffer

github-actions bot commented Dec 6, 2022

Firmware for this pull request:
Firmware.zip


          Merge branch 'MobiFlight:main' into wo_NameBuffer

adb6875

github-actions bot commented Dec 8, 2022

Firmware for this pull request:
Firmware.zip


          Merge branch 'main' into wo_NameBuffer

145e4b8

github-actions bot commented Dec 8, 2022

Firmware for this pull request:
Firmware.zip


          Merge branch 'main' into wo_NameBuffer

9895bd1

github-actions bot commented Dec 9, 2022

Firmware for this pull request:
Firmware.zip

elral added 2 commits

December 12, 2022 10:04


          new handler ID's for inputs to differ from old way

fab649d


          double definition for input shifter change deleted

eb11e8b

github-actions bot commented Dec 12, 2022

Firmware for this pull request:
Firmware.zip


          deleted unused variable

e5faee9

github-actions bot commented Dec 14, 2022

Firmware for this pull request:
Firmware.zip


          Merge branch 'main' into wo_NameBuffer

00790f5

github-actions bot commented Jan 6, 2023

Firmware for this pull request:
Firmware.zip


          Merge branch 'MobiFlight:main' into wo_NameBuffer

318852a

github-actions bot commented Jan 6, 2023

Firmware for this pull request:
Firmware.zip


          Merge branch 'MobiFlight:main' into wo_NameBuffer

8dc8a3a

github-actions bot commented Jan 10, 2024

Firmware for this pull request:
Firmware.zip


          Merge branch 'MobiFlight:main' into wo_NameBuffer

2ae2c7f

github-actions bot commented Jan 10, 2024

Firmware for this pull request:
Firmware.zip


          Merge branch 'MobiFlight:main' into wo_NameBuffer

67fda32

github-actions bot commented May 5, 2024

Firmware for this pull request:
Firmware.zip

elral added 2 commits

May 6, 2024 09:04


          Merge main

2dccc8a


          Merge branch 'wo_NameBuffer' of https://github.com/elral/MobiFlight-F…

b84f846

…irmwareSource into wo_NameBuffer

github-actions bot commented May 6, 2024

Firmware for this pull request:
Firmware.zip


          Merge branch 'MobiFlight:main' into wo_NameBuffer

5dd1791

github-actions bot commented May 24, 2024

Board and firmware folder for this pull request:
Mobiflight-Connector.zip


          Merge branch 'main' into wo_NameBuffer

a18e839

github-actions bot commented May 28, 2024

Board and firmware folder for this pull request:
Mobiflight-Connector.zip


          Merge branch 'main' into wo_NameBuffer

c3f9d38

github-actions bot commented Sep 5, 2024

Board and firmware folder for this pull request:
Mobiflight-Connector.zip


          Merge branch 'MobiFlight:main' into wo_NameBuffer

7ee0e51

github-actions bot commented Sep 17, 2024

Board and firmware folder for this pull request:
Mobiflight-Connector.zip


          Merge branch 'MobiFlight:main' into wo_NameBuffer

5c87b39

github-actions bot commented Oct 1, 2024

Board and firmware folder for this pull request:
Mobiflight-Connector.zip


          Merge branch 'MobiFlight:main' into wo_NameBuffer

fed89d1

github-actions bot commented Oct 22, 2024

Board and firmware folder for this pull request:
Mobiflight-Connector.zip


          Merge branch 'main' into wo_NameBuffer

89b9b25

github-actions bot commented Oct 27, 2024

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

DocMoebiuz marked this pull request as draft

January 6, 2025 19:58


          Merge branch 'MobiFlight:main' into wo_NameBuffer

7c6c984

github-actions bot commented Jan 6, 2025

Board and firmware folder for this pull request:
Mobiflight-Connector.zip


          Merge branch 'main' into wo_NameBuffer

45038a8

github-actions bot commented Feb 12, 2025

Board and firmware folder for this pull request:
Mobiflight-Connector.zip

Collaborator Author

elral commented Feb 24, 2025

There is no real demand for now to implement this feature. Also with all the memory optimazations from the past RAM is no real bottleneck anymore. We are short for some boards, but it's working. Additional features are also limited by available flash for some boards.
For future features it might also be sensefull to send the names instead of the deviceID.

elral closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet