Open
Conversation
|
Build for this pull request: |
ColinM9991
force-pushed
the
restructure-repo
branch
from
c92bf65 to
60cbd3f
Compare
ColinM9991
force-pushed
the
restructure-repo
branch
from
60cbd3f to
4b7debc
Compare
ColinM9991
force-pushed
the
restructure-repo
branch
from
1b4fceb to
89acadf
Compare
|
Build for this pull request: |
|
Build for this pull request: |
|
Build for this pull request: |
|
Build for this pull request: |
|
Build for this pull request: |
|
Build for this pull request: |
|
Build for this pull request: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prepare for an upcoming .NET Core migration, this pull request restructures the repository to follow a more conventional structure containing
srcandtestsdirectories.The .NET Core SDK includes items automatically via glob patterns and so it is pertinent that projects are segregated. While it's possible to exclude files within the csproj file that could get quite messy and introduce risk down the line where files may accidentally be included in projects that they shouldn't be in.
A diff of the MobiFlightConnector.zip from this PR compared alongside a known good zip yields a positive result that shows the only left orphans (files in the known good but missing after this restructure) are the frontend/distassets that are hashed when generated, meaning the file name will always be different across runs.
Note
Please don't merge without first validating the release process
Although I've updated some YAML workflow files, I have not tested the full release process to ensure the final artifact (that is attached to GitHub releases) is correct. This is where I will need some steer in terms of how this process is run locally.