Skip to content

Add missing pins A6 and A7 to nano#1236

Merged
DocMoebiuz merged 3 commits intoMobiFlight:mainfrom
neilenns:issue1221-missing-nano-pins
Jun 18, 2023
Merged

Add missing pins A6 and A7 to nano#1236
DocMoebiuz merged 3 commits intoMobiFlight:mainfrom
neilenns:issue1221-missing-nano-pins

Conversation

@neilenns
Copy link
Contributor

@neilenns neilenns commented Jun 3, 2023

Fixes #1228

Adds the missing A6 and A7 pins to the nano board file and increases the max number of analog pins to 8.

While the two pins work without a firmware change, the firmware also needs to update to have a max analog pin count of 8 for all the pins to be usable at the same time (see #1228)

@neilenns neilenns requested a review from DocMoebiuz as a code owner June 3, 2023 17:25
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

Build for this pull request:
MobiFlightConnector.zip

@elral
Copy link
Contributor

elral commented Jun 6, 2023

@neilenns could you add the ProMicro on this PR to increase the max. numbers of Analog Input to 9 as this PR is still open?

I have issued a PR for the firmware change on Nano and ProMicro, see PR 248.

@neilenns
Copy link
Contributor Author

neilenns commented Jun 6, 2023

@elral Updated the PR with the Pro Micro max increased to 9, and also added names to the analog pins that didn't have analog names attached.

I used this for reference: https://learn.sparkfun.com/tutorials/pro-micro--fio-v3-hookup-guide

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Build for this pull request:
MobiFlightConnector.zip

@elral
Copy link
Contributor

elral commented Jun 7, 2023

I double checked the pin assignemt.

The ProMicro does not have Pin D17, but this one is on the json file.
The "original" board is just named "Micro", and this board has additional pins (11/12/13/17/22/23).
We could

  • add these additional pins to the json file. If one isn't available on the board, it can not be connected
  • "just" support the ProMicro, but then we have to delete Pin 17.

@neilenns @DocMoebiuz Any idea how to handle this?

The Nano has Pin 20 and 21, but they can only be used as Anlog In. I guess we do not have a marker to avoid that they show up as digital in. Furthermore these both pins are marked as I2C in this PR, but they aren't.

@neilenns
Copy link
Contributor Author

neilenns commented Jun 7, 2023

  • Removed pin D17 from the ProMicro file.
  • Fixed the incorrect I2C marking for A6 and A7 on the nano

Regarding Micro vs. Pro Micro, Mobiflight website says we support the pro micro so the file should reflect that. you are correct, there is no way currently to avoid having the analog pins show up as digital.

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Build for this pull request:
MobiFlightConnector.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase analog input support in Pro Micro and Nano

3 participants