Skip to content

Single component redraw fix #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Single component redraw fix #743

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6dafefd
Single component redraw fix
dhinesh03 Jul 28, 2015
be60f8c
Js lint error clean up
dhinesh03 Jul 30, 2015
c0972ba
Removed trailing whitespace and added space after comma
dhinesh03 Jul 31, 2015
44f0310
Necessary config functions has been invoked after self-redraw
dhinesh03 Aug 31, 2015
11dc7c2
configs - array not initialized while self redraw issue fixed
dhinesh03 Aug 31, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions mithril.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,10 +460,23 @@ var m = (function app(window, undefined) {
return data;
}

function buildObject(data, cached, editable, parentElement, index, shouldReattach, namespace, configs) {
function buildObject(parentElement, parentTag, parentCache, parentIndex, data, cached, shouldReattach, index, editable, namespace, configs) {
var views = [], controllers = [];
data = markViews(data, cached, views, controllers);
if (!data.tag && controllers.length) throw new Error("Component template must return a virtual element, not an array, string, etc.");
// Single component redraw fix
for (var i = 0; i < controllers.length; i++) {
var controller = controllers[i];
if (isFunction(controller.redrawSelf)) {
controller.redrawSelf = (function(ctrl,view) {
Copy link
Contributor

@Naddiseo Naddiseo Jul 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jslinterrors.com/dont-make-functions-within-a-loop

return function() {
m.redraw.strategy('none');
var newData = view(ctrl);
build(parentElement, parentTag, parentCache, parentIndex, newData, cached, shouldReattach, index, editable, namespace, configs);
}
})(controller, views[i]);
}
}
data.attrs = data.attrs || {};
cached.attrs = cached.attrs || {};
var dataAttrKeys = Object.keys(data.attrs);
Expand Down Expand Up @@ -544,7 +557,7 @@ var m = (function app(window, undefined) {
if (data.subtree === "retain") return cached;
cached = makeCache(data, cached, index, parentIndex, parentCache);
return isArray(data) ? buildArray(data, cached, parentElement, index, parentTag, shouldReattach, editable, namespace, configs) :
data != null && isObject(data) ? buildObject(data, cached, editable, parentElement, index, shouldReattach, namespace, configs) :
data != null && isObject(data) ? buildObject(parentElement, parentTag, parentCache, parentIndex, data, cached, shouldReattach, index, editable, namespace, configs) :
!isFunction(data) ? handleText(cached, data, index, parentElement, shouldReattach, editable, parentTag) :
cached;
}
Expand Down