Actually run command tests#44
Open
vascop wants to merge 12 commits intoMiserlou:masterfrom
vascop:feature-fix-tests
Open
Actually run command tests#44vascop wants to merge 12 commits intoMiserlou:masterfrom vascop:feature-fix-tests
vascop wants to merge 12 commits intoMiserlou:masterfrom
vascop:feature-fix-tests
Conversation
Contributor
Author
|
Bah, the tests are failing because I'm developing assuming garnaat/placebo#44 is going to be merged and pushed to pypi. Forgot that I changed it locally before opening this. I'll go sleep now. |
Owner
|
This has been merged upstream into placebo 0.8.1, now on pip. Looking forward to having this PR merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a big PR, related to issue #36. It refactors the settings loading part of the tests, changes the way arguments were being passed (most of the were passed as lists), adds a "follow" argument to the tail command, and adds placebo runs to all of the commands.
The tail command is not actually being tested because I didn't have a clear idea on how to actually do it. It has the placebo run though, so if anyone wants to, they can just use that.