Skip to content

Refactor: Remove redundant message state sync in ChatContainer#4941

Open
shatfield4 wants to merge 2 commits intomasterfrom
4940-refactor-remove-redundant-message-state-in-chatcontainer
Open

Refactor: Remove redundant message state sync in ChatContainer#4941
shatfield4 wants to merge 2 commits intomasterfrom
4940-refactor-remove-redundant-message-state-in-chatcontainer

Conversation

@shatfield4
Copy link
Collaborator

@shatfield4 shatfield4 commented Jan 30, 2026

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #4940

  • Fixes the pending chat indicator (3 dot animation) rerendering/flickering when typing in the input while waiting for a
    response
  • message state in ChatContainer was updating on every keystroke, causing unnecessary rerenders of the entire chat history including the pending indicator (pending indicator was the only visible bug but the entire history was actually rerendering)
  • Removed redundant message state sync since PromptInput already maintains its own local state and now reads from DOM on submit instead

What is in this change?

Additional Information

  • Sent regular chat and no longer rerenders 3 dot animation while message is pending
  • Test STT in both auto submit and append mode
  • Localstorage draft messages store properly
  • Slash commands pops up on / typed into chat input
  • Agent meny pops up on @ typed into chat input
  • Pasted text pastes properly
  • Undo/redo works properly
  • Enter to submit chat, shift + enter creates new line

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

Copy link
Contributor

@angelplusultra angelplusultra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…940-refactor-remove-redundant-message-state-in-chatcontainer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REFACTOR]: Remove redundant message state in ChatContainer

3 participants