Skip to content

Add batch embedding support for Ollama embedding provider #4553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 25, 2025
Merged

Add batch embedding support for Ollama embedding provider #4553

merged 6 commits into from
Nov 25, 2025
+79 −15

Conversation

@shatfield4
Copy link
Collaborator

@shatfield4 shatfield4 commented Oct 16, 2025 •
edited
Loading

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #4529

What is in this change?

  • Switched embed() call to use input param vs the old prompt param to support batch processing
  • Adds new advanced options item to allow for adjusting batch size in Ollama provider (default is 1)
  • Updated logging to show batch sizes and progress

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@shatfield4 shatfield4 added the PR:needs review Needs review by core team label Oct 16, 2025
@shatfield4 shatfield4 linked an issue Oct 16, 2025 that may be closed by this pull request
[FEAT]: OllamaEmbedder Support Batched or Parallel Embeddings to Improve Performance #4529
Closed
@shatfield4
Merge branch 'master' into 4529-feat-ollamaembedder-support-batched-o…
98f943c 
…r-parallel-embeddings-to-improve-performance
timothycarambat added a commit that referenced this pull request Nov 20, 2025
@timothycarambat
Implmenet chat and agentic chat user-id for OpenRouter
5057abd 
resolves #4553
closes #4482
@timothycarambat timothycarambat mentioned this pull request Nov 20, 2025
Merged
9 tasks
timothycarambat added a commit that referenced this pull request Nov 20, 2025
@timothycarambat
Implement full chat and @agent chat user indentificiation for Ope…
cf76bad 
…nRouter (#4668)

Implmenet chat and agentic chat user-id for OpenRouter
resolves #4553
closes #4482
timothycarambat
timothycarambat requested changes Nov 25, 2025
View reviewed changes
Copy link
Member

@timothycarambat timothycarambat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See question/feedback on input param

@timothycarambat timothycarambat removed the PR:needs review Needs review by core team label Nov 25, 2025
@timothycarambat timothycarambat merged commit 66e44f6 into master Nov 25, 2025
1 check passed
@timothycarambat timothycarambat deleted the 4529-feat-ollamaembedder-support-batched-or-parallel-embeddings-to-improve-performance branch November 25, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timothycarambat timothycarambat Awaiting requested review from timothycarambat

Assignees

@timothycarambat timothycarambat

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEAT]: OllamaEmbedder Support Batched or Parallel Embeddings to Improve Performance

3 participants

@shatfield4 @timothycarambat