fix handling of specified command environment in create_cmd_scripts + add test for env option in run_shell_cmd
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add test for env option in run_shell_cmd
Micket
reviewed
May 30, 2024
easybuild/tools/run.py
Outdated
| if not key.endswith('%')) + '\n') | ||
|
|
||
| # unset environment variables in current environment if they're not defined in environment used to run command | ||
| fid.write('\n'.join(f'unset {key}' for key in os.environ if key not in env and not key.endswith('%'))) |
Owner
There was a problem hiding this comment.
hm, this isn't really correct though? When a user sources this, they will likely have other variables set.
It should unset everything the user has as the point where they enter this environment?
unset $(env | cut -d= -f1)
I suppose we should maybe always do that (first) since the user might be bringing in their own extra stuff when they source env.sh.
Micket
pushed a commit
that referenced
this pull request
Apr 14, 2025
move `CWD_NOTFOUND_ERROR` constant to `tools.build_log`
Micket
pushed a commit
that referenced
this pull request
Oct 11, 2025
extend `test_toy_cuda_sanity_check` to also check whether shared libraries under `lib/python*/site-packages` are being checked in CUDA sanity check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Micket one more for easybuilders#4486