Skip to content

Fix broken mctc installation CMake files #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

Fix broken mctc installation CMake files #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion easybuild/easyconfigs/m/mctc-lib/mctc-lib-0.5.0-GCC-14.3.0.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@ toolchainopts = {'pic': True}
github_account = 'grimme-lab'
source_urls = [GITHUB_SOURCE]
sources = ['v%(version)s.tar.gz']
checksums = ['ed0276618b9e1b41b5d228aedd4a1e07500472cfab5236179feb0cb55a0c8dc3']
patches = ['mctc-lib-0.5.0_fix-install-template.patch']
checksums = [
# v0.5.0.tar.gz
'ed0276618b9e1b41b5d228aedd4a1e07500472cfab5236179feb0cb55a0c8dc3',
# mctc-lib-0.5.0_fix-install-template.patch
'647c77ba4bd4ce78090c7f3dd60ccbc7d4263320ac53572e98fef7bc46135a20',
]

builddependencies = [
('binutils', '2.44'),
Expand Down
38 changes: 38 additions & 0 deletions easybuild/easyconfigs/m/mctc-lib/mctc-lib-0.5.0_fix-install-template.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
Fix error in installed CMake file, which leads to config failures later on
when trying to use the package:

```
The link interface of target "mctc-lib::mctc-lib-lib" contains:

OpenMP::OpenMP_Fortran

but the target was not found. Possible reasons include:
```

Instead of using a string, we should use the actual value.
Tested manually with enabling and disabling OpenMP, which results in the
desired effect.

Author: Jan Andre Reuter (JSC)

diff --color -Naur mctc-lib-0.5.0.orig/config/template.cmake mctc-lib-0.5.0/config/template.cmake
--- mctc-lib-0.5.0.orig/config/template.cmake 2025-09-04 09:48:19.000000000 +0200
+++ mctc-lib-0.5.0/config/template.cmake 2025-10-30 09:59:50.463210351 +0100
@@ -8,14 +8,14 @@

include(CMakeFindDependencyMacro)

- if(NOT TARGET "OpenMP::OpenMP_Fortran" AND "@PROJECT_NAME@_WITH_OpenMP")
+ if(NOT TARGET "OpenMP::OpenMP_Fortran" AND @PROJECT_NAME@_WITH_OpenMP)
find_dependency("OpenMP")
endif()

- if(NOT TARGET "toml-f::toml-f" AND "@PROJECT_NAME@_WITH_JSON")
+ if(NOT TARGET "toml-f::toml-f" AND @PROJECT_NAME@_WITH_JSON)
find_dependency("toml-f")
endif()
- if(NOT TARGET "jonquil::jonquil" AND "@PROJECT_NAME@_WITH_JSON")
+ if(NOT TARGET "jonquil::jonquil" AND @PROJECT_NAME@_WITH_JSON)
find_dependency("jonquil")
endif()
endif()