Automatically register object types implementing used interface type #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalLytek
force-pushed
the
interface-auto-registering
branch
from
862ee22 to
331fe54
Compare
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 94.96% 94.94% -0.02%
==========================================
Files 78 78
Lines 1390 1405 +15
Branches 271 275 +4
==========================================
+ Hits 1320 1334 +14
- Misses 67 68 +1
Partials 3 3
Continue to review full report at Codecov.
|
Closed
MichalLytek
force-pushed
the
interface-auto-registering
branch
from
4bfe6fa to
c759ff9
Compare
MichalLytek
force-pushed
the
interface-auto-registering
branch
from
c759ff9 to
7cbae98
Compare
MichalLytek
force-pushed
the
interface-auto-registering
branch
from
7cbae98 to
6dcceac
Compare
|
Thanks for this, it looks good to me. :^) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature that automatically emit in schema all the object types that implements the interface types referenced in schema definition.
It also adds an option to disable the auto register feature per interface type, like the
Nodeinterface case for Relay-based system, in case of multiple schemas isolation.Closes #568