fix(resolvers): resolve #1142 name issue and add relevant tests #1309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russell-dot-js
approved these changes
Aug 19, 2022
rafaell-lycan
approved these changes
Nov 1, 2022
MichalLytek
added
Community 👨👧
|
I'm sorry I got some emails today from github regarding this repo but I don't understand. Am I supposed to do something? |
|
Nope, i just set myself as a reviewer to not forget about this PR, don't worry 😉 |
MichalLytek
force-pushed
the
master
branch
4 times, most recently
from
a190360 to
f50d1d0
Compare
MichalLytek
force-pushed
the
name-underscore-fix
branch
from
beade62 to
8074c56
Compare
MichalLytek
approved these changes
Jan 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1309 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 113 113
Lines 1848 1848
Branches 364 364
=======================================
Hits 1765 1765
Misses 83 83 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue mentioned here with tests as mentioned here.
The tests successfully fail when the
startsWithis replaced back withincludes.(Edit: The second 'here' is supposed to link to the last comment of the mentioned issue but it's not scrolling.)