-
-
Notifications
You must be signed in to change notification settings - Fork 23
Migrate to TypeScript #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
df27bfe
Add description to package
whymarrh a8d6d0f
Convert project to TypeScript
whymarrh 710e962
Scope package under @metamask
whymarrh 805bff0
Update README import statement
whymarrh 4a94d2a
Add .nvmrc file
whymarrh 97c1d2c
Factor out ESLint config
whymarrh 45ddded
ESLint fixes
whymarrh 8eb1242
Pull ESLint config from npm
whymarrh d9e3ed1
Add basic CircleCI config
whymarrh a02a610
Fix spelling in package description
whymarrh af2a400
Update tsconfig.json module field
whymarrh 058bb0d
Update tsconfig.json target
whymarrh 09b65ff
Mark .d.ts files as generated
whymarrh 9a40331
Update ESLint config to override env for JS files
whymarrh 312b552
Add Jest config
whymarrh 860e176
Remove Reflect shim
whymarrh 293351a
Inline array lengths were appropriate
whymarrh 78b9a36
Simplify tsconfig.json file
whymarrh 2f76321
ci: Add build to CI jobs
whymarrh 6250be8
ci: Rename workflow
whymarrh 2ae9c10
Clean up dependencies
whymarrh 435bd7d
Update package contents
whymarrh d1c757b
Update eslint file extensions
whymarrh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # http://editorconfig.org | ||
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| end_of_line = lf | ||
| indent_size = 2 | ||
| indent_style = space | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [*.md] | ||
| indent_size = 4 | ||
| trim_trailing_whitespace = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| *.js | ||
| node_modules | ||
| dist | ||
| coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,169 @@ | ||
| module.exports = { | ||
| root: true, | ||
| parser: '@typescript-eslint/parser', | ||
| plugins: [ | ||
| '@typescript-eslint', | ||
| 'jest', | ||
| ], | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:@typescript-eslint/eslint-recommended', | ||
| 'plugin:@typescript-eslint/recommended', | ||
| ], | ||
| env: { | ||
| node: true, | ||
| 'jest/globals': true | ||
| }, | ||
| rules: { | ||
| "accessor-pairs": 2, | ||
| "arrow-spacing": [2, { "before": true, "after": true }], | ||
| "block-spacing": [2, "always"], | ||
| "brace-style": 0, | ||
| "camelcase": [2, { "properties": "never", "allow": ["^UNSAFE_"] }], | ||
| "comma-dangle": [2, "always-multiline"], | ||
| "comma-spacing": [2, { "before": false, "after": true }], | ||
| "comma-style": [2, "last"], | ||
| "constructor-super": 2, | ||
| "curly": 2, | ||
| "default-case": 2, | ||
| "dot-location": [2, "property"], | ||
| "eol-last": 2, | ||
| "eqeqeq": [2, "allow-null"], | ||
| "generator-star-spacing": [2, { "before": true, "after": true }], | ||
| "handle-callback-err": [2, "^(err|error)$" ], | ||
| "indent": 0, | ||
| "jsx-quotes": [2, "prefer-double"], | ||
| "key-spacing": 2, | ||
| "keyword-spacing": [2, { "before": true, "after": true }], | ||
| "new-cap": [2, { "newIsCap": true, "capIsNew": false }], | ||
| "new-parens": 2, | ||
| "no-array-constructor": 0, | ||
| "no-async-promise-executor": "error", | ||
| "no-caller": 2, | ||
| "no-class-assign": 2, | ||
| "no-cond-assign": 2, | ||
| "no-confusing-arrow": 2, | ||
| "no-const-assign": 2, | ||
| "no-control-regex": 2, | ||
| "no-debugger": 2, | ||
| "no-delete-var": 2, | ||
| "no-dupe-args": 2, | ||
| "no-dupe-class-members": 2, | ||
| "no-dupe-keys": 2, | ||
| "no-duplicate-case": 2, | ||
| "no-duplicate-imports": 2, | ||
| "no-empty-character-class": 2, | ||
| "no-empty-pattern": 2, | ||
| "no-eval": 2, | ||
| "no-ex-assign": 2, | ||
| "no-extend-native": 2, | ||
| "no-extra-bind": 2, | ||
| "no-extra-boolean-cast": 2, | ||
| "no-extra-parens": [2, "functions"], | ||
| "no-fallthrough": 2, | ||
| "no-floating-decimal": 2, | ||
| "no-func-assign": 2, | ||
| "no-implied-eval": 2, | ||
| "no-inner-declarations": [2, "functions"], | ||
| "no-invalid-regexp": 2, | ||
| "no-irregular-whitespace": 2, | ||
| "no-iterator": 2, | ||
| "no-label-var": 2, | ||
| "no-labels": [2, { "allowLoop": false, "allowSwitch": false }], | ||
| "no-lone-blocks": 2, | ||
| "no-mixed-spaces-and-tabs": 2, | ||
| "no-multi-spaces": 2, | ||
| "no-multi-str": 2, | ||
| "no-multiple-empty-lines": [2, { "max": 2 }], | ||
| "no-native-reassign": 2, | ||
| "no-negated-in-lhs": 2, | ||
| "no-new": 2, | ||
| "no-new-func": 2, | ||
| "no-new-object": 2, | ||
| "no-new-require": 2, | ||
| "no-new-symbol": 2, | ||
| "no-new-wrappers": 2, | ||
| "no-obj-calls": 2, | ||
| "no-octal": 2, | ||
| "no-octal-escape": 2, | ||
| "no-path-concat": 2, | ||
| "no-proto": 2, | ||
| "no-redeclare": 2, | ||
| "no-regex-spaces": 2, | ||
| "no-return-assign": [2, "except-parens"], | ||
| "no-self-assign": 2, | ||
| "no-self-compare": 2, | ||
| "no-sequences": 2, | ||
| "no-shadow-restricted-names": 2, | ||
| "no-spaced-func": 2, | ||
| "no-sparse-arrays": 2, | ||
| "no-this-before-super": 2, | ||
| "no-throw-literal": 2, | ||
| "no-trailing-spaces": 2, | ||
| "no-undef": 2, | ||
| "no-undef-init": 2, | ||
| "no-unexpected-multiline": 2, | ||
| "no-unmodified-loop-condition": 2, | ||
| "no-unneeded-ternary": [2, { "defaultAssignment": false }], | ||
| "no-unreachable": 2, | ||
| "no-unsafe-finally": 2, | ||
| "no-unused-expressions": 0, | ||
| "no-unused-vars": 0, | ||
| "no-use-before-define": 0, | ||
| "no-useless-call": 2, | ||
| "no-useless-computed-key": 2, | ||
|
|
||
rekmarks marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "no-useless-escape": 2, | ||
| "no-var": 2, | ||
| "no-whitespace-before-property": 2, | ||
| "no-with": 2, | ||
| "object-curly-spacing": [2, "always"], | ||
| "one-var": [2, { "initialized": "never" }], | ||
| "operator-linebreak": [2, "after", { "overrides": { "?": "ignore", ":": "ignore" } }], | ||
| "padded-blocks": "off", | ||
| "prefer-const": 2, | ||
| "quotes": 0, | ||
| "semi": 0, | ||
| "semi-spacing": [2, { "before": false, "after": true }], | ||
| "space-before-blocks": [2, "always"], | ||
| "space-before-function-paren": 0, | ||
| "space-in-parens": [2, "never"], | ||
| "space-infix-ops": 2, | ||
| "space-unary-ops": [2, { "words": true, "nonwords": false }], | ||
| "spaced-comment": [2, "always", { "markers": ["global", "globals", "eslint", "eslint-disable", "*package", "!", ","], "exceptions": ["=", "-"] } ], | ||
| "template-curly-spacing": [2, "never"], | ||
| "use-isnan": 2, | ||
| "valid-typeof": 2, | ||
| "wrap-iife": [2, "any"], | ||
| "yield-star-spacing": [2, "both"], | ||
| "yoda": [2, "never"], | ||
|
|
||
| '@typescript-eslint/array-type': 2, | ||
| "@typescript-eslint/consistent-type-definitions": [2, "type"], | ||
| '@typescript-eslint/no-explicit-any': 0, | ||
| '@typescript-eslint/prefer-for-of': 0, | ||
| '@typescript-eslint/prefer-function-type': 2, | ||
| '@typescript-eslint/prefer-optional-chain': 2, | ||
| '@typescript-eslint/triple-slash-reference': 2, | ||
| '@typescript-eslint/type-annotation-spacing': 2, | ||
| '@typescript-eslint/typedef': 0, | ||
| '@typescript-eslint/unified-signatures': 2, | ||
|
|
||
| "@typescript-eslint/brace-style": 2, | ||
| '@typescript-eslint/default-param-last': 2, | ||
| '@typescript-eslint/func-call-spacing': 2, | ||
| "@typescript-eslint/indent": [2, 2,{ "SwitchCase": 1 }], | ||
| '@typescript-eslint/no-array-constructor': 2, | ||
| '@typescript-eslint/no-empty-function': 2, | ||
| '@typescript-eslint/no-extra-parens': 0, | ||
| '@typescript-eslint/no-extra-semi': 2, | ||
| '@typescript-eslint/no-magic-numbers': 0, | ||
| "@typescript-eslint/no-unused-expressions": [2, { "allowShortCircuit" : true, "allowTernary": true }], | ||
| "@typescript-eslint/no-unused-vars": [2, { "vars": "all", "args": "all", "argsIgnorePattern": "[_]+" }], | ||
| "@typescript-eslint/no-use-before-define": [2, { "functions": false }], | ||
| "@typescript-eslint/no-useless-constructor": 2, | ||
| "@typescript-eslint/quotes": [2, "single", {"avoidEscape": true, "allowTemplateLiterals": true}], | ||
| '@typescript-eslint/semi': [2, "always"], | ||
| "@typescript-eslint/space-before-function-paren": [2, "always"], | ||
| } | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| * text=auto | ||
|
|
||
| # Reviewing the lockfile contents is an important step in verifying that | ||
| # we're using the dependencies we expect to be using | ||
| package-lock.json linguist-generated=false | ||
| yarn.lock linguist-generated=false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| .idea | ||
| .editorconfig | ||
| .eslintignore | ||
| .eslintrc.js | ||
| .gitattributes | ||
| *.tgz | ||
| *.ts | ||
| !*.d.ts | ||
| tsconfig.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.