chore(ci): lint Podfile.lock #9789
Closed
+81
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
legobeat
added
devtools
area-testSuite
team-application-security
legobeat
force-pushed
the
ci-lint-podfile-lock
branch
5 times, most recently
from
dc86200 to
3481e51
Compare
7 tasks
legobeat
force-pushed
the
ci-lint-podfile-lock
branch
4 times, most recently
from
b6624ce to
84bd73a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9789 +/- ##
=======================================
Coverage 47.24% 47.24%
=======================================
Files 1370 1370
Lines 33304 33304
Branches 3586 3586
=======================================
Hits 15736 15736
Misses 16607 16607
Partials 961 961 ☔ View full report in Codecov by Sentry. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
- Makes linting fail if `Podfile.lock` is out of sync. - chore(ci): install ruby for lint job
…by versions
fix: script phases warning (#35594)
stderr output:
warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
Upstream-commit: 48966ebce1fe1a5a7b5f9ce6b9224b751ee0d98b (#35594)
Co-authored-by: Ricky Hanlon <[email protected]>
legobeat
force-pushed
the
ci-lint-podfile-lock
branch
from
de1cd9d to
3214e9f
Compare
|
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
Contributor
|
This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions. |
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
## **Description** This PR refactors setup.mjs file with the purpose of: 1. Moves Gemfile into iOS directory, which is where it belongs since it only relates to iOS. We also updated everywhere that calls bundle install or exec so it's calling it in the ios directory 2. Run pod install in CI for detecting diffs in Podfile.lock Because we're now running pod install in the CI, the total `ci.yml` job time will take longer. However, it still completes before some other tasks such as unit tests. And since it runs in parallel to those, we should not see an increase in total CI run time. ## **Related issues** - #11293 - #9789 ## **Manual testing steps** - Running `yarn setup` still works normally when run locally - CI passes when run - CI fails when Podfile.lock is changed when pod install runs in the CI ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> Example of pod file diff detected https://github.com/MetaMask/metamask-mobile/actions/runs/10746121351/job/29806449687?pr=10880 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: legobt <[email protected]> Co-authored-by: legobeat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pod:installscript and call it fromsetup.mjsinstead of duplicating the commandpod:installas part of lint jobPodfile.lockis out of sync.Related issues
Manual testing steps
PodfilePodfilechange and pushScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist